PHOENIX-7266 Fix SSLConfigDir in ITs #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoty
reviewed
Mar 8, 2024
| @@ -51,6 +51,10 @@ public class TlsUtil { | |||
| protected static final String TARGET_DIR_NAME = System.getProperty("target.dir", "target"); | |||
| protected static final File TARGET_DIR = | |||
| new File(System.getProperty("user.dir"), TARGET_DIR_NAME); | |||
| protected static final String TEST_CLASSES_DIR_NAME = | |||
There was a problem hiding this comment.
A few lines of comments on what is happening here would be useful.
There was a problem hiding this comment.
I'm not sure about this, as these are just directory names, there isn't really a complex logic behind them. There are very similar definitions in the preceding lines without comments as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.