-
Notifications
You must be signed in to change notification settings - Fork 65
PHOENIX-7600 - Replace commons-logging with slf4j #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new JAR also needs to be added the /lib directory in the assembly, and to the startup python scripts.
Did the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new jar is not added to the assembly.
Please fix the orchestrator dependency check error. probably copying this from phoenix-queryserver-it will fix it:
|
Added the ignoreNonCompile true line to orchestrator, now it built locally with the mvn -B clean verify -DskipTests command, which was failing on github (without the -DskipTests). |
I've started the CI run |
No description provided.