Skip to content

PHOENIX-7600 - Replace commons-logging with slf4j #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2025

Conversation

meszinorbi
Copy link
Contributor

No description provided.

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new JAR also needs to be added the /lib directory in the assembly, and to the startup python scripts.

@meszinorbi
Copy link
Contributor Author

Did the requested changes.

@meszinorbi meszinorbi requested a review from stoty May 12, 2025 12:36
Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new jar is not added to the assembly.

@stoty
Copy link
Contributor

stoty commented May 15, 2025

Please fix the orchestrator dependency check error.

probably copying this from phoenix-queryserver-it will fix it:

     <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-dependency-plugin</artifactId>
        <configuration>
          <!-- dependency:analyze is quite useless for hadoop test dependencies -->
          <ignoreNonCompile>true</ignoreNonCompile>
        </configuration>
      </plugin>

@meszinorbi
Copy link
Contributor Author

Added the ignoreNonCompile true line to orchestrator, now it built locally with the mvn -B clean verify -DskipTests command, which was failing on github (without the -DskipTests).

@stoty
Copy link
Contributor

stoty commented May 15, 2025

I've started the CI run

@stoty stoty merged commit 662f0ff into apache:master May 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants