Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-7487: Make table level max lookback accept lookback value in seconds instead of milli-seconds to be consistent with TTL #2065

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sanjeet006py
Copy link
Contributor

Summary of the changes:

  • User will specify table level max lookback age in seconds in DDL.
  • The value in seconds will be converted to milli-seconds before storing it in SYSCAT. Thus, SYSCAT will contain table level max lookback age in milli-seconds.
  • Property values key map in PTableImpl stores table level max lookback age in seconds as this map is for constructing DDLs dynamically.

…seconds instead of milli-seconds to be consistent with TTL
@sanjeet006py
Copy link
Contributor Author

@tkhurana @virajjasani @jpisaac can you please review the PR. It will be great if we can merge this before 5.3 release to not worry about backward compatibility of user interface. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant