PHOENIX-7524 Resolve character encoding mismatch by enforcing UTF-8 in sqlline.py #2081
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue with certain characters, such as Japanese, Polish, and other non-ASCII characters, being exported incorrectly has been resolved. The root cause was an encoding mismatch, where character data was not properly handled in the `java_cmd` command in `sqlline.py`. This command constructs and executes a Java process to launch SQLLine, a command-line tool for executing SQL queries against Apache Phoenix. To address this, the `sqlline.py` file was modified to explicitly enforce UTF-8 encoding. This ensures that all character data is correctly encoded and exported, preventing data corruption or misinterpretation due to incorrect encoding settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with certain characters, such as Japanese, Polish, and other non-ASCII characters, being exported incorrectly has been resolved. The root cause was an encoding mismatch, where character data was not properly handled in the
java_cmdcommand insqlline.py. This command constructs and executes a Java process to launch SQLLine, a command-line tool for executing SQL queries against Apache Phoenix.To address this, the
sqlline.pyfile was modified to explicitly enforce UTF-8 encoding.This ensures that all character data is correctly encoded and exported, preventing data corruption or misinterpretation due to incorrect encoding settings.