Use different ingestion delay metrics for backfill topics #16852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16852 +/- ##
============================================
+ Coverage 63.50% 63.55% +0.05%
Complexity 1419 1419
============================================
Files 3080 3080
Lines 181451 181458 +7
Branches 27787 27788 +1
============================================
+ Hits 115227 115331 +104
+ Misses 57357 57259 -98
- Partials 8867 8868 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
this one looks good, please address the merge conflict. |
deemoliu
reviewed
Oct 8, 2025
| _serverMetrics.setOrUpdatePartitionGauge(_metricName, partitionId, ServerGauge.REALTIME_INGESTION_DELAY_MS, | ||
| () -> getPartitionIngestionDelayMs(partitionId)); | ||
| } | ||
| if (firstStreamIngestionTimeMs > 0) { |
There was a problem hiding this comment.
if (firstStreamIngestionTimeMs > 0)
what does this check used for? do we still need it?
lnbest0707-uber
force-pushed
the
upstream-fork_reset_metrics
branch
from
28c7f40 to
cb16bf7
Compare
lnbest0707-uber
force-pushed
the
upstream-fork_reset_metrics
branch
from
cb16bf7 to
61d00ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
observabilityThe backfill topics may inherit the source topic's timestamp (e.g. Kafka metadata). In such use case, we want to track how users can consume the latest data. The backfill should have a different metrics to track latency.