-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add pinot-cli: interactive and batch command-line client #17029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new pinot-cli module providing a modern command-line interface for Apache Pinot with both interactive REPL and batch execution capabilities.
Key changes:
- Interactive REPL with multi-line SQL support, command history, and optional pager integration
- Multiple output formats (CSV, TSV, JSON, ALIGNED, VERTICAL, AUTO, MARKDOWN) for flexible data presentation
- Configuration support via properties files and environment variables with session option forwarding
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| pinot-clients/pom.xml | Added pinot-cli module to the parent POM's modules list |
| pinot-clients/pinot-cli/pom.xml | Maven configuration for the new CLI module with dependencies and shaded JAR build |
| pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java | Main CLI implementation with REPL, batch execution, and formatting logic |
| pinot-clients/pinot-cli/README.md | Comprehensive documentation for CLI usage, configuration, and examples |
pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java
Outdated
Show resolved
Hide resolved
pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java
Outdated
Show resolved
Hide resolved
pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java
Outdated
Show resolved
Hide resolved
pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java
Outdated
Show resolved
Hide resolved
pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java
Show resolved
Hide resolved
5b7c670 to
0a67ce4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java
Outdated
Show resolved
Hide resolved
pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java
Show resolved
Hide resolved
pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java
Outdated
Show resolved
Hide resolved
pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java
Outdated
Show resolved
Hide resolved
pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java
Outdated
Show resolved
Hide resolved
pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java
Show resolved
Hide resolved
pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java
Outdated
Show resolved
Hide resolved
pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java
Show resolved
Hide resolved
pinot-clients/pinot-cli/src/main/java/org/apache/pinot/cli/PinotCli.java
Show resolved
Hide resolved
b14df23 to
6289912
Compare
Adds a new
pinot-climodule providing a modern CLI for Apache Pinot:PINOT_CONFIG) and environment variables, forwards session optionsBuild:
./mvnw -DskipTests -pl pinot-clients/pinot-cli -am package
Artifacts:
Notes:
pinot-jdbc-client,picocli, andjlineALIGNED;AUTOswitches based on terminal width