property

snazy · snazy · commit 0dc46a3240f2 · 2025-05-09T16:38:10.000+02:00
diff --git a/plugins/spark/v3.5/regtests/docker-compose.yml b/plugins/spark/v3.5/regtests/docker-compose.yml
@@ -30,7 +30,7 @@ services:
       quarkus.otel.sdk.disabled: "true"
       polaris.features.defaults."ALLOW_INSECURE_STORAGE_TYPES": "true"
       polaris.features.defaults."SUPPORTED_CATALOG_STORAGE_TYPES": "[\"FILE\",\"S3\",\"GCS\",\"AZURE\"]"
-      polaris.readiness.ignore-security-issues: "true"
+      polaris.readiness.ignore-severe-issues: "true"
     healthcheck:
       test: ["CMD", "curl", "http://localhost:8182/q/health"]
       interval: 10s
diff --git a/quarkus/defaults/src/main/resources/application-it.properties b/quarkus/defaults/src/main/resources/application-it.properties
@@ -42,7 +42,7 @@ polaris.features.defaults."INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_it"=true
 polaris.features.defaults."SKIP_CREDENTIAL_SUBSCOPING_INDIRECTION"=true
 polaris.features.defaults."SUPPORTED_CATALOG_STORAGE_TYPES"=["FILE","S3","GCS","AZURE"]
 polaris.features.defaults."ENABLE_CATALOG_FEDERATION"=true
-polaris.readiness.ignore-security-issues=true
+polaris.readiness.ignore-severe-issues=true
 
 polaris.realm-context.realms=POLARIS,OTHER
 
diff --git a/quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/ProductionReadinessChecks.java b/quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/ProductionReadinessChecks.java
@@ -101,13 +101,13 @@ public void warnOnFailedChecks(
               "Refer to https://polaris.apache.org/in-dev/unreleased/configuring-polaris-for-production for more information.");
 
       if (hasSevere) {
-        if (!config.ignoreSecurityIssues()) {
+        if (!config.ignoreSevereIssues()) {
           throw new IllegalStateException(
               "Severe production readiness issues detected, startup aborted!");
         }
         LOGGER.error(
             "{} severe production readiness issues detected, but user explicitly requested startup by setting "
-                + "polaris.readiness.ignore-security-issues=true and accepts the risk of denial-of-service, "
+                + "polaris.readiness.ignore-severe-issues=true and accepts the risk of denial-of-service, "
                 + "data-loss, corruption and others !",
             severe);
       }
diff --git a/quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusReadinessConfiguration.java b/quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusReadinessConfiguration.java
@@ -32,5 +32,5 @@ public interface QuarkusReadinessConfiguration {
    * risks.
    */
   @WithDefault("false")
-  boolean ignoreSecurityIssues();
+  boolean ignoreSevereIssues();
 }
diff --git a/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/admin/PolarisAuthzTestBase.java b/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/admin/PolarisAuthzTestBase.java
@@ -120,7 +120,7 @@ public Map<String, String> getConfigOverrides() {
           "true",
           "polaris.features.defaults.\"SUPPORTED_CATALOG_STORAGE_TYPES\"",
           "[\"FILE\",\"S3\"]",
-          "polaris.readiness.ignore-security-issues",
+          "polaris.readiness.ignore-severe-issues",
           "true");
     }
   }
diff --git a/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/GenericTableCatalogTest.java b/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/GenericTableCatalogTest.java
@@ -113,7 +113,7 @@ public Map<String, String> getConfigOverrides() {
           "true",
           "polaris.features.defaults.\"SUPPORTED_CATALOG_STORAGE_TYPES\"",
           "[\"FILE\"]",
-          "polaris.readiness.ignore-security-issues",
+          "polaris.readiness.ignore-severe-issues",
           "true");
     }
   }
diff --git a/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java b/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java
@@ -175,7 +175,7 @@ public Map<String, String> getConfigOverrides() {
           "[\"FILE\",\"S3\"]",
           "polaris.event-listener.type",
           "test",
-          "polaris.readiness.ignore-security-issues",
+          "polaris.readiness.ignore-severe-issues",
           "true");
     }
   }
diff --git a/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogViewTest.java b/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogViewTest.java
@@ -113,7 +113,7 @@ public Map<String, String> getConfigOverrides() {
           "[\"FILE\",\"S3\"]",
           "polaris.event-listener.type",
           "test",
-          "polaris.readiness.ignore-security-issues",
+          "polaris.readiness.ignore-severe-issues",
           "true");
     }
   }
diff --git a/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/PolicyCatalogTest.java b/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/PolicyCatalogTest.java
@@ -128,7 +128,7 @@ public Map<String, String> getConfigOverrides() {
           "[\"FILE\"]",
           "polaris.features.defaults.\"ALLOW_INSECURE_STORAGE_TYPES\"",
           "true",
-          "polaris.readiness.ignore-security-issues",
+          "polaris.readiness.ignore-severe-issues",
           "true");
     }
   }
diff --git a/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/it/QuarkusApplicationIntegrationTest.java b/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/it/QuarkusApplicationIntegrationTest.java
@@ -64,7 +64,7 @@ public Map<String, String> getConfigOverrides() {
           "true",
           "polaris.features.defaults.\"SUPPORTED_CATALOG_STORAGE_TYPES\"",
           "[\"FILE\",\"S3\"]",
-          "polaris.readiness.ignore-security-issues",
+          "polaris.readiness.ignore-severe-issues",
           "true");
     }
   }
diff --git a/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/it/QuarkusPolicyServiceIntegrationTest.java b/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/it/QuarkusPolicyServiceIntegrationTest.java
@@ -38,7 +38,7 @@ public Map<String, String> getConfigOverrides() {
           "true",
           "polaris.features.defaults.\"SUPPORTED_CATALOG_STORAGE_TYPES\"",
           "[\"FILE\",\"S3\"]",
-          "polaris.readiness.ignore-security-issues",
+          "polaris.readiness.ignore-severe-issues",
           "true");
     }
   }
diff --git a/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/it/QuarkusRestCatalogIntegrationTest.java b/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/it/QuarkusRestCatalogIntegrationTest.java
@@ -41,7 +41,7 @@ public Map<String, String> getConfigOverrides() {
           "true",
           "polaris.features.defaults.\"SUPPORTED_CATALOG_STORAGE_TYPES\"",
           "[\"FILE\",\"S3\"]",
-          "polaris.readiness.ignore-security-issues",
+          "polaris.readiness.ignore-severe-issues",
           "true");
     }
   }
diff --git a/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/it/QuarkusRestCatalogViewFileIntegrationTest.java b/quarkus/service/src/test/java/org/apache/polaris/service/quarkus/it/QuarkusRestCatalogViewFileIntegrationTest.java
@@ -43,7 +43,7 @@ public Map<String, String> getConfigOverrides() {
           "true",
           "polaris.features.defaults.\"SUPPORTED_CATALOG_STORAGE_TYPES\"",
           "[\"FILE\"]",
-          "polaris.readiness.ignore-security-issues",
+          "polaris.readiness.ignore-severe-issues",
           "true");
     }
   }
diff --git a/regtests/docker-compose.yml b/regtests/docker-compose.yml
@@ -36,7 +36,7 @@ services:
       quarkus.otel.sdk.disabled: "true"
       polaris.features.defaults."ALLOW_INSECURE_STORAGE_TYPES": "true"
       polaris.features.defaults."SUPPORTED_CATALOG_STORAGE_TYPES": "[\"FILE\",\"S3\",\"GCS\",\"AZURE\"]"
-      polaris.readiness.ignore-security-issues: "true"
+      polaris.readiness.ignore-severe-issues: "true"
     volumes:
       - ./credentials:/tmp/credentials/
     healthcheck:

Original file line number	Diff line number	Diff line change
`@@ -32,5 +32,5 @@ public interface QuarkusReadinessConfiguration {`
`32`	`32`	`* risks.`
`33`	`33`	`*/`
`34`	`34`	`@WithDefault("false")`
`35`		`- boolean ignoreSecurityIssues();`
	`35`	`+ boolean ignoreSevereIssues();`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ public Map<String, String> getConfigOverrides() {`
`120`	`120`	`"true",`
`121`	`121`	`"polaris.features.defaults.\"SUPPORTED_CATALOG_STORAGE_TYPES\"",`
`122`	`122`	`"[\"FILE\",\"S3\"]",`
`123`		`- "polaris.readiness.ignore-security-issues",`
	`123`	`+ "polaris.readiness.ignore-severe-issues",`
`124`	`124`	`"true");`
`125`	`125`	`}`
`126`	`126`	`}`
Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ public Map<String, String> getConfigOverrides() {`
`113`	`113`	`"true",`
`114`	`114`	`"polaris.features.defaults.\"SUPPORTED_CATALOG_STORAGE_TYPES\"",`
`115`	`115`	`"[\"FILE\"]",`
`116`		`- "polaris.readiness.ignore-security-issues",`
	`116`	`+ "polaris.readiness.ignore-severe-issues",`
`117`	`117`	`"true");`
`118`	`118`	`}`
`119`	`119`	`}`
Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ public Map<String, String> getConfigOverrides() {`
`175`	`175`	`"[\"FILE\",\"S3\"]",`
`176`	`176`	`"polaris.event-listener.type",`
`177`	`177`	`"test",`
`178`		`- "polaris.readiness.ignore-security-issues",`
	`178`	`+ "polaris.readiness.ignore-severe-issues",`
`179`	`179`	`"true");`
`180`	`180`	`}`
`181`	`181`	`}`
Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ public Map<String, String> getConfigOverrides() {`
`128`	`128`	`"[\"FILE\"]",`
`129`	`129`	`"polaris.features.defaults.\"ALLOW_INSECURE_STORAGE_TYPES\"",`
`130`	`130`	`"true",`
`131`		`- "polaris.readiness.ignore-security-issues",`
	`131`	`+ "polaris.readiness.ignore-severe-issues",`
`132`	`132`	`"true");`
`133`	`133`	`}`
`134`	`134`	`}`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ public Map<String, String> getConfigOverrides() {`
`64`	`64`	`"true",`
`65`	`65`	`"polaris.features.defaults.\"SUPPORTED_CATALOG_STORAGE_TYPES\"",`
`66`	`66`	`"[\"FILE\",\"S3\"]",`
`67`		`- "polaris.readiness.ignore-security-issues",`
	`67`	`+ "polaris.readiness.ignore-severe-issues",`
`68`	`68`	`"true");`
`69`	`69`	`}`
`70`	`70`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public Map<String, String> getConfigOverrides() {`
`38`	`38`	`"true",`
`39`	`39`	`"polaris.features.defaults.\"SUPPORTED_CATALOG_STORAGE_TYPES\"",`
`40`	`40`	`"[\"FILE\",\"S3\"]",`
`41`		`- "polaris.readiness.ignore-security-issues",`
	`41`	`+ "polaris.readiness.ignore-severe-issues",`
`42`	`42`	`"true");`
`43`	`43`	`}`
`44`	`44`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public Map<String, String> getConfigOverrides() {`
`41`	`41`	`"true",`
`42`	`42`	`"polaris.features.defaults.\"SUPPORTED_CATALOG_STORAGE_TYPES\"",`
`43`	`43`	`"[\"FILE\",\"S3\"]",`
`44`		`- "polaris.readiness.ignore-security-issues",`
	`44`	`+ "polaris.readiness.ignore-severe-issues",`
`45`	`45`	`"true");`
`46`	`46`	`}`
`47`	`47`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public Map<String, String> getConfigOverrides() {`
`43`	`43`	`"true",`
`44`	`44`	`"polaris.features.defaults.\"SUPPORTED_CATALOG_STORAGE_TYPES\"",`
`45`	`45`	`"[\"FILE\"]",`
`46`		`- "polaris.readiness.ignore-security-issues",`
	`46`	`+ "polaris.readiness.ignore-severe-issues",`
`47`	`47`	`"true");`
`48`	`48`	`}`
`49`	`49`	`}`