Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] CatalogAdmin should be able to list principal roles #363

Open
collado-mike opened this issue Oct 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@collado-mike
Copy link
Contributor

Is your feature request related to a problem? Please describe.

By default, a principal that has a catalog_admin role in a catalog cannot list principal roles using the API. The catalog_admin's responsibility is managing privileges and access to the catalog roles in a catalog. After fixing #359 , the catalog_admin has the ability to grant a catalog role to a principal role, but has no ability to see the list of available principal roles. This may be ok for cases where a principal has both the service_admin and the catalog_admin roles, but if there's an enforced separation, the lack of privilege to list principal roles is a hindrance.

Describe the solution you'd like

The authorization model typically requires a catalog to be in the scope of a request in order to detect that user has catalog_admin on the specified catalog. However, PrincipalRoles are not tied to a catalog, so it's difficult for the current authorization workflow to know if the current user does have admin privilege on any catalog. We can consider a separate API, where the /principal_roles endpoint is prefixed by catalog, but that feels cumbersome - especially if the caller is an admin on multiple catalogs.

A more likely solution would be to manage a special PrincipalRole that has limited privileges on PrincipalRoles (and possibly Principals) that a user is automatically added to when granted catalog_admin.

Describe alternatives you've considered

No response

Additional context

No response

@collado-mike collado-mike added the enhancement New feature or request label Oct 9, 2024
@collado-mike collado-mike changed the title [FEATURE REQUEST] CatalogAdmin cannot list principal roles [FEATURE REQUEST] CatalogAdmin should be able to list principal roles Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant