Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - AWS_REGION mandatory - AWS STS client instantiated inside PolarisService not in PolarisCore #368

Open
1 task done
lefebsy opened this issue Oct 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@lefebsy
Copy link

lefebsy commented Oct 14, 2024

Is this a possible security vulnerability?

  • This is NOT a possible security vulnerability

Describe the bug

Hello,
Maybe I am wrong and this is an expected behavior.

If there is no AWS_REGION setted in the environnement where Polaris is running (inMemory), the action of creating a catalog throw an error during the initialization of the STS Client.

To Reproduce

  • Do not have AWS_REGION setted in environnement running Polaris
  • start Polaris in mode "InMemory" (metaStoreManagerFactory == InMemoryPolarisMetaStoreManagerFactory)
  • after Polaris is started with success
  • create a catalog (with curl by example)
  • STSClient fail during instantiation in polaris-service/src/main/java/org/apache/polaris/service/PolarisApplication.java line 160 (metaStoreManagerFactory)

Actual Behavior

  • In polaris-service/src/main/java/org/apache/polaris/service/PolarisApplication.java
  • line 160 the PolarisStorageIntegrationProviderImpl will try to intantiate by default a AWS stsClient
  • without AWS_REGION setted, it's failing

Expected Behavior

  • Maybe let the "Polaris Core" storage implementation fully manage this STS client (why is it instantiated in the "Polaris Service" ?)
  • Maybe set a default Region in the STSbuilder to avoid an error ?

Additional context

In case of a GCP or Azure deployment, AWS_REGION should not be mandatory.

System information

Dev mode

@lefebsy lefebsy added the bug Something isn't working label Oct 14, 2024
@lefebsy lefebsy changed the title [BUG] - AWS_REGION mandatory ? [BUG] - AWS_REGION mandatory - AWS STS client instantiated inside PolarisService not in PolarisCore Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant