Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support set connectionTimeout param #410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shibd
Copy link
Member

@shibd shibd commented Mar 26, 2025

Motivation

In the C++ client, the connectionTimeout parameter controls the time allowed to establish a connection, with a default value of 10 seconds

https://github.com/apache/pulsar-client-cpp/blob/4ba83e83fbb4319c0b4cda82372caf042e9ccaa6/lib/ClientConnection.cc#L184-L185

We need to expose this config on node.js client.

Modifications

  • The pulsar_client structure definition from the C++ client has been copied, allowing node.js client to set it using the C++ API instead of the C API.
  • Expose connectionTimeoutMs configuration

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@shibd shibd self-assigned this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant