New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Prometheus scrape annotations when podmonitors are enabled #590

Merged

lhotari merged 1 commit into apache:master from lhotari:lh-remove-prometheus-annotations-when-podmonitors-are-enabled

Mar 7, 2025

Member

lhotari commented Mar 7, 2025

Motivation

Having scrape annotations while the podmonitor objects are present doesn't make sense

Modifications

Don't add annotations when podmonitor is enabled for a component
Add missing annotations for Zookeeper pods

Verifying this change

Make sure that the change passes the CI checks.


          Remove Prometheus scrape annotations when podmonitors are enabled

37c8efa

lhotari merged commit 75119dd into apache:master

32 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet