[fix][broker] Correct the 'connected' status in topic stats of multi-partition topic for geo replication #23523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
reviewed
Nov 5, 2024
| @@ -4354,6 +4354,7 @@ CompletableFuture<Message<byte[]>> examineMessageAsync(String topic, String init | |||
| * | |||
| * @param topic | |||
| * @param applied | |||
| * Whether to return the configuration value of the previous level if the current level's don't set | |||
There was a problem hiding this comment.
Is this update related to this pull request? If not, please remove from this PR and improve the javadoc in a separate PR.
| @@ -4364,6 +4365,7 @@ CompletableFuture<Message<byte[]>> examineMessageAsync(String topic, String init | |||
| * | |||
| * @param topic | |||
| * @param applied | |||
| * Whether to return the configuration value of the previous level if the current level's don't set | |||
There was a problem hiding this comment.
Is this update related to this pull request? If not, please remove from this PR and improve the javadoc in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The default value of the
connectedfield inorg.apache.pulsar.common.policies.data.stats.ReplicatorStatsImplis false, and the logic for accumulating each partition (org.apache.pulsar.common.policies.data.stats.ReplicatorStatsImpl#add) isthis.connected &= stats.connected;. This causes the status of a multi-partition topic to always be false after calculation, and it is impossible to truly feedback the correct status of the geo replication task.Modifications
Modify the
connectedfield inorg.apache.pulsar.common.policies.data.stats.ReplicatorStatsImplfrom false to true.Documentation
docdoc-requireddoc-not-neededdoc-complete