[fix][broker] Fix some problems in calculate totalAvailableBookies in method getExcludedBookiesWithIsolationGroups when some bookies belongs to multiple isolation groups.

[hanmz]

Motivation

Currently, the values ​​of totalAvailableBookiesInPrimaryGroup and totalAvailableBookiesFromPrimaryAndSecondary may not be accurate because there may be repeated accumulation when some bookies belongs to multiple isolation groups.

For example: There are 3 bookies in total and has 3 group, the distribution is as follows
Group1: bk1
Group2: bk2,bk3
Group3: bk1
When primaryIsolationGroup contains Group1 and Group3, secondaryIsolationGroup contains Group2, when execute the method getExcludedBookiesWithIsolationGroups(2, groups[primaryIsolationGroup,secondaryIsolationGroup]). The correct return value should be empty but current return bk2 and bk3.

The calculation of totalAvailableBookiesFromPrimaryAndSecondary has similar problems.

Modifications

Fix the calculation logic of totalAvailableBookiesInPrimaryGroup and totalAvailableBookiesFromPrimaryAndSecondary.

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

[lhotari]

LGTM, good work @hanmz

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.24%. Comparing base (bbc6224) to head (480443a).
Report is 980 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #24091      +/-   ##
============================================
+ Coverage     73.57%   74.24%   +0.67%     
+ Complexity    32624    32445     -179     
============================================
  Files          1877     1863      -14     
  Lines        139502   144315    +4813     
  Branches      15299    16460    +1161     
============================================
+ Hits         102638   107150    +4512     
+ Misses        28908    28706     -202     
- Partials       7956     8459     +503     

Flag	Coverage Δ
inttests	26.67% <0.00%> (+2.09%)	⬆️
systests	23.17% <0.00%> (-1.15%)	⬇️
unittests	73.74% <100.00%> (+0.89%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...areness/IsolatedBookieEnsemblePlacementPolicy.java	87.21% <100.00%> (+0.19%)	⬆️

... and 1061 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.