[improve][meta] Add byte size limit to AbstractMetadataStore's childrenCache #24868
+44
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
nodece
approved these changes
Oct 21, 2025
Technoboy-
reviewed
Oct 22, 2025
| // when a lot of namespaces with lots of topics are listed in the metadata store. | ||
| long defaultSizeBytes = heapMaxSizeBytes / 5; | ||
| // min size 20MB | ||
| int minSizeBytes = 1024 * 1024 * 20; |
There was a problem hiding this comment.
It would be better if it were configurable
Technoboy-
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
AbstractMetadataStore contains an unbounded childrenCache which might consume a lot of heap memory when a lot of namespaces with a lot of topics are listed. The cache has a timeout of 10 minutes so the memory usage problem is limited to certain use cases. For example, when all topics are listed for all namespaces in less than 10 minutes when there are a lot of namespaces and topics.
Modifications
Add a limit to the childrenCache so that oldest entries start to get expired when the cache consumes more than 20% of the maximum heap size.
Tests are TBD.
Documentation
docdoc-requireddoc-not-neededdoc-complete