RANGER-5369: policy engine support for service-managed ACLs - inline-policy #722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneethiraj
requested review from
Copilot,
kulkabhay,
kumaab,
pradeepagrawal8184,
rameeshm,
sneethiraj,
spolavarpau1 and
vperiasamy
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for inline policies in the Ranger policy engine by adding a RangerInlinePolicy field to access requests. This enables service-managed ACLs to be evaluated alongside regular Ranger policies.
- Adds a new
RangerInlinePolicymodel class with support for ENFORCING and COMPLEMENTARY modes - Integrates inline policy support into the access request interface and implementations
- Provides getter/setter methods for inline policy across all access request classes
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| RangerInlinePolicy.java | New model class defining inline policy structure with Grant inner class |
| RangerAccessRequest.java | Adds default getInlinePolicy() method to the interface |
| RangerAccessRequestImpl.java | Implements inline policy field with getter/setter and toString support |
| RangerAccessRequestWrapper.java | Delegates getInlinePolicy() to wrapped request |
| RangerAccessRequestReadOnly.java | Delegates getInlinePolicy() to source request |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestImpl.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
WIP patch: added RangerInitialPolicy in RangerAccessRequest to support policy engine to evaluate inline-policy