refactor(c/sedona-s2geography): Move s2geography UDFs to extension ABI#683
Draft
paleolimbot wants to merge 9 commits intoapache:mainfrom
Draft
refactor(c/sedona-s2geography): Move s2geography UDFs to extension ABI#683paleolimbot wants to merge 9 commits intoapache:mainfrom
paleolimbot wants to merge 9 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR that migrates UDFs to use the sedona-extension ABI instead of one specifically invented for Geography (history being that the geography one came first and that I added the extension one after some experience writing the first one). The benefit here is that we get to remove almost all of the wrapper code on the Rust side because we already test the sedona-extension wrapper in isolation. This forces a tiny bit of wrapper code on to C++ but so far it is not too bad.
This PR updates the s2geography submodule to point to paleolimbot/s2geography#75 (and to main once that merges).