Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support collecting the access log from Kubernetes #107

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

mrproliu
Copy link
Contributor

Support network data collection for all Kubernetes processes in the configuration, and generate corresponding access logs to be sent to the backend.

@mrproliu mrproliu marked this pull request as draft December 25, 2023 12:33
@mrproliu mrproliu changed the title Support collecting the access log from Kubernetes [WIP] Support collecting the access log from Kubernetes Dec 25, 2023
@mrproliu mrproliu added the enhancement New feature or request label Dec 25, 2023
@mrproliu mrproliu added this to the 0.6.0 milestone Dec 25, 2023
@mrproliu mrproliu marked this pull request as ready for review December 25, 2023 13:47
@mrproliu mrproliu changed the title [WIP] Support collecting the access log from Kubernetes Support collecting the access log from Kubernetes Dec 25, 2023
@wu-sheng
Copy link
Member

I don't have enough knowledge to review your details. Do you have anything that needs my confirmation? Otherwise, I could approve and merge this anyway.

Question, e2e requires SkyWalking OAP implementation gets done first, right? So, only local manual tests are done for this.

@wu-sheng
Copy link
Member

Please update the readme, repository description, and docs through another PR. We need to state, this agent is for monitoring and profiling

@mrproliu
Copy link
Contributor Author

I don't have enough knowledge to review your details. Do you have anything that needs my confirmation? Otherwise, I could approve and merge this anyway.

For now, nothing needs to be confirm.

Question, e2e requires SkyWalking OAP implementation gets done first, right? So, only local manual tests are done for this.

Yes, I only tests in my local machine. After the OAP side been finished, I will add the E2E cases in the both side(OAP and Rover).

@wu-sheng wu-sheng merged commit c979bbf into apache:main Dec 25, 2023
28 checks passed
@mrproliu mrproliu deleted the monitor-base branch December 26, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants