[SPARK-43365] Refactor Dockerfile and workflow based on base image #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yikun
commented
May 4, 2023
Comment on lines
+68
to
+70
| mv python/pyspark /opt/spark/python/pyspark/; \ | ||
| mv python/lib /opt/spark/python/lib/; \ | ||
| mv R /opt/spark/; \ |
Member
Author
There was a problem hiding this comment.
download/extract spark (maybe keeping python and R files too? they seem relatively small compared to the rest)
This the key change:
2.0M ./lib
11M ./pyspark
5.6M ./R
Compare to complete docker image size (500-600MB), I think it can be accepted, otherwise we have to keep download/extract/move these step into Pyspark/R dockerfiles.
Member
Author
|
also cc @yosifkit This PR address question 1 of docker-library/official-images#13089 |
9 tasks
HyukjinKwon
approved these changes
May 5, 2023
Member
Author
|
@HyukjinKwon Thanks! Merged. |
|
Late LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR changes Dockerfile and workflow based on base image to save space by sharing layers by having one image from another.
After this PR:
./add-dockerfiles.sh 3.4.0to make it work.[1] docker-library/official-images#13089
Why are the changes needed?
Address DOI comments, and also to save space by sharing layers by having one image from another.
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI passed.