Open
Conversation
Remove dropFunctionsInDatabase and DROP DATABASE registry clearing from this branch; they live on SPARK-55964-cache-coherence. This branch keeps only system-catalog priority / resolution-order changes.
…tifiers.scala Co-authored-by: Wenchen Fan <cloud0fan@gmail.com>
…log/SessionCatalog.scala Co-authored-by: Wenchen Fan <cloud0fan@gmail.com>
…figEntry conflicts
…ixin - normalizeFuncName asserts fully qualified 3-part identifiers and lowercases all parts - BuiltinRegistryMixin lets builtin/internal registries accept simple names - Simplify resolutionCandidates: flat if/else, no inline qualification - Rename resolveQualifiedFunction -> resolveFunctionCandidate - Remove namespaceToIdentifier, TEMP_FUNCTION_DB; reuse SESSION_NAMESPACE_TEMPLATE - identifierFromSystemNameParts reuses FunctionResolution.sessionNamespaceKind - Simplify listBuiltinAndTempFunctions, isBuiltinFunction(String) - SparkSessionExtensions: only register 1-part names for backward compatibility Co-authored-by: Isaac
Simplify function registry: enforce 3-part keys, add BuiltinRegistryMixin
srielau
force-pushed
the
SPARK-54810-path
branch
from
a9e735d to
228bfa9
Compare
…patibility The function registry requires fully qualified (3-part: catalog.database.funcName) identifiers. Update 'fork new session and inherit function registry and udf' test to use tempFuncId with SYSTEM_CATALOG_NAME and SESSION_NAMESPACE so dropFunction and lookupFunction receive 3-part identifiers.
…ysis/FunctionResolution.scala Co-authored-by: Wenchen Fan <cloud0fan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support SQL Standard
SPARK-54810-path-plan.md
Why are the changes needed?
Give users control over the order in which to resolev objecst in different schemas.
Does this PR introduce any user-facing change?
Yes, this is a new feature
How was this patch tested?
Added a new test suite
Was this patch authored or co-authored using generative AI tooling?
Yes, Claude Opus 4.6 high