Skip to content

[SPARK-55851][PYTHON][FOLLOW-UP] Deal with NotImplementedError for partitions() #54871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaogaotiantian wants to merge 2 commits into from
Closed

[SPARK-55851][PYTHON][FOLLOW-UP] Deal with NotImplementedError for partitions() #54871

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d6ed4c
Deal with NotImplementedError for partitions()
gaogaotiantian Mar 17, 2026
2e855de
Fix mypy
gaogaotiantian Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion python/pyspark/sql/worker/plan_data_source_read.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,12 @@ def data_source_read_func(iterator: Iterable[pa.RecordBatch]) -> Iterable[pa.Rec

if not is_streaming:
# The partitioning of python batch source read is determined before query execution.
partitions = reader.partitions() # type: ignore[call-arg]
try:
partitions = reader.partitions() # type: ignore[call-arg]
except NotImplementedError:
# Backward compatibility for data sources that raise NotImplementedError for partitions
# Our old base class did this so an old client may still be using it.
partitions = [InputPartition(None)]
if not isinstance(partitions, list):
raise PySparkRuntimeError(
errorClass="DATA_SOURCE_TYPE_MISMATCH",
Expand Down