[Bug] Fix parameters of the Permission of the flink/savepoint/trigger interface are confused #4169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… interface are confused
|
wolfboys
reviewed
Jan 15, 2025
|
|
||
| @PostMapping("trigger") | ||
| @Permission(app = "#savepoint.appId", team = "#savepoint.teamId") | ||
| @Permission(app = "#appId", team = "#teamId") |
Member
There was a problem hiding this comment.
@Permission parameter team is not bind, there is no teamId in request parameter
Contributor
Author
There was a problem hiding this comment.
@wolfboys Do we want to change it to this?
@Permission(app = "#appId")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… interface are confused
What changes were proposed in this pull request
Issue Number: close #4168
Brief change log
Modify the parameters of the Permission of the flink/savepoint/trigger interface
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts