Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): Add Conditional Scroll prevention. #30837

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(dashboard): Add Conditional Scroll prevention. #30837

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54a0e41
Add conditional scroll prevention
Srayash Nov 4, 2024
920c53d
Merge branch 'apache:master' into Srayash/Issue#30756
Srayash Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@ const DashboardContainer: FC<DashboardContainerProps> = ({ topLevelTabs }) => {
// prevent window from jumping down when tabbing
// if already at the top of the page
// to help with accessibility when using keyboard navigation
window.scrollTo(window.scrollX, 0);
// Only scroll when needed for tab focus navigation
window.scrollTo(0, 0);
}
}}
>
Expand Down
Loading