Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update doc about CSV upload #30867

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

seiyab
Copy link

@seiyab seiyab commented Nov 7, 2024

SUMMARY

Docs about CSV upload is stale. I update it to match current UI.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

NOTE: not full difference.
Before:
image

After:
image

TESTING INSTRUCTIONS

N/A. Just updating doc.

ADDITIONAL INFORMATION

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Nov 7, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@seiyab seiyab marked this pull request as ready for review November 7, 2024 13:50
@dosubot dosubot bot added the data:csv Related to import/export of CSVs label Nov 7, 2024
@michael-s-molina michael-s-molina changed the title Update doc about CSV upload docs: Update doc about CSV upload Nov 7, 2024
seiyab and others added 2 commits November 9, 2024 09:16
Co-authored-by: Evan Rusackas <[email protected]>
Co-authored-by: Evan Rusackas <[email protected]>
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the help here!

And congrats on the first commit. Feel free to add your org to the In the Wild Page, too!

@seiyab
Copy link
Author

seiyab commented Nov 11, 2024

Thank you for your review.
Our organization has not decided to use Superset yet. I will add it when I will contribute Superset again after our org stating to use it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:csv Related to import/export of CSVs doc Namespace | Anything related to documentation size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants