fix: blocks UI elements on right side #30886
Conversation
superset-frontend/src/dashboard/components/gridComponents/ChartHolder.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Evan Rusackas <[email protected]>
|
hey @rusackas !! can i connect with you on slack or something, i have some doubts regarding the setup of the codebase |
|
By all means, slack away... or start a GitHub Discussion and tag me there if you want more eyes on it. |
rusackas
changed the title
superset-frontend/src/dashboard/components/gridComponents/ChartHolder.tsx
Outdated
Show resolved
Hide resolved
| @@ -32,6 +32,7 @@ import ResizableContainer from 'src/dashboard/components/resizable/ResizableCont | |||
| import getChartAndLabelComponentIdFromPath from 'src/dashboard/util/getChartAndLabelComponentIdFromPath'; | |||
| import useFilterFocusHighlightStyles from 'src/dashboard/util/useFilterFocusHighlightStyles'; | |||
| import { COLUMN_TYPE, ROW_TYPE } from 'src/dashboard/util/componentTypes'; | |||
| import { useTheme } from '@superset-ui/core'; | |||
There was a problem hiding this comment.
Ahh, you can add this import to line 25, so you're not importing stuff from superset-ui/core twice (it's a listing error). Sorry, I should have been clearer. Also, sorry you even have to DO this stuff... but it's all stuff that sets things up better for the next person :)
| @@ -69,13 +70,14 @@ interface ChartHolderProps { | |||
| setFullSizeChartId: (chartId: number | null) => void; | |||
| isInView: boolean; | |||
| } | |||
|
|
|||
| const theme=useTheme() | |||
There was a problem hiding this comment.
Looks like this (and the style const below it) might need to go within the function component... or there are other workarounds for that. Holler if you want any help here, I might be able to push commits to your fork/branch
|
hey @rusackas , can you check it now |
|
@samarsrivastav looks like there are some failures with pre-commit hooks. Mind running them? |
fix(dashboard): load charts correctly
Fixes #30879
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
shown in the issue #30879
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION