Skip to content

fix(dataset): render default URL description properly in settings #35669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

fix(dataset): render default URL description properly in settings #35669

merged 1 commit into from
Oct 16, 2025
+10 −4

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Oct 15, 2025 •
edited
Loading

SUMMARY

Fixes the dataset edit modal's default URL field description which was displaying escaped HTML tags as plain text instead of rendering them properly.

The description text included <span style=„white-space: nowrap;"> tags that were being shown literally to users. This has been replaced with proper React JSX using Typography.Text component with the code prop to display the example URL path /superset/dashboard/{id}/ in a code-formatted style.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: The description showed raw HTML text:

Default URL to redirect to when accessing from the dataset list page. Accepts relative URLs such as <span style=„white-space: nowrap;">/superset/dashboard/{id}/</span>
Screenshot 2025-10-16 at 9 53 57 AM

After: The description now renders properly with the example URL in code format:

Screenshot 2025-10-16 at 9 53 05 AM

TESTING INSTRUCTIONS

  1. Navigate to any dataset
  2. Click "Edit Dataset"
  3. Go to the "Settings" tab
  4. Locate the "Default URL" field
  5. Verify the description text displays properly with the example path /superset/dashboard/{id}/ shown in code format (not as escaped HTML)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

🤖 Generated with Claude Code

@betodealmeida @claude
fix(dataset): render default URL description properly in settings
ec70a9c 
The default URL field description was displaying escaped HTML tags as plain text instead of rendering them. Replaced HTML string with proper React JSX using Typography.Text component to display the example URL path in code format.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@korbit-ai Korbit AI
Copy link

korbit-ai bot commented Oct 15, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@bito-code-review Bito Code Review
Copy link
Contributor

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

@betodealmeida betodealmeida marked this pull request as ready for review October 16, 2025 13:27
korbit-ai[bot]
korbit-ai bot approved these changes Oct 16, 2025
View reviewed changes
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned ​
File Path Reviewed
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx ✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@betodealmeida betodealmeida added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Oct 16, 2025
@github-actions github-actions bot added 🎪 ec70a9c 🚦 building Environment ec70a9c status: building 🎪 ec70a9c 📅 2025-10-16T13-38 Environment ec70a9c created at 2025-10-16T13-38 🎪 ec70a9c ⌛ 48h Environment ec70a9c expires after 48h 🎪 ec70a9c 🤡 betodealmeida Environment ec70a9c requested by betodealmeida and removed 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR labels Oct 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

🎪 Showtime is building environment on GHA for ec70a9c

@github-actions github-actions bot added 🎪 ec70a9c 🚦 deploying Environment ec70a9c status: deploying and removed 🎪 ec70a9c 🚦 building Environment ec70a9c status: building labels Oct 16, 2025
@betodealmeida
Copy link
Member Author

/review

@github-actions github-actions bot added 🎪 ec70a9c 🚦 running Environment ec70a9c status: running 🎪 🎯 ec70a9c Active environment pointer - ec70a9c is receiving traffic 🎪 ec70a9c 🌐 54.188.63.112:8080 Environment ec70a9c URL: http://54.188.63.112:8080 (click to visit) and removed 🎪 ec70a9c 🚦 deploying Environment ec70a9c status: deploying 🎪 ec70a9c 🚦 running Environment ec70a9c status: running 🎪 🎯 ec70a9c Active environment pointer - ec70a9c is receiving traffic labels Oct 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

🎪 Showtime deployed environment on GHA for ec70a9c

• Environment: http://54.188.63.112:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

@betodealmeida betodealmeida merged commit f405174 into master Oct 16, 2025
127 of 128 checks passed
@betodealmeida betodealmeida deleted the fix-dataset-default-url-description branch October 16, 2025 18:27
@sadpandajoe sadpandajoe added the v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch label Oct 16, 2025
sadpandajoe pushed a commit that referenced this pull request Oct 16, 2025
@betodealmeida @claude @sadpandajoe
fix(dataset): render default URL description properly in settings (#3…
3bfd4ef 
…5669)

Co-authored-by: Claude <[email protected]>
(cherry picked from commit f405174)
@dosubot dosubot bot added change:frontend Requires changing the frontend data:dataset Related to dataset configurations labels Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sadpandajoe sadpandajoe sadpandajoe approved these changes

+2 more reviewers

@aminghadersohi aminghadersohi aminghadersohi approved these changes

@korbit-ai korbit-ai[bot] korbit-ai[bot] approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

change:frontend Requires changing the frontend data:dataset Related to dataset configurations 🎪 ec70a9c 🤡 betodealmeida Environment ec70a9c requested by betodealmeida 🎪 ec70a9c 🚦 running Environment ec70a9c status: running 🎪 ec70a9c ⌛ 48h Environment ec70a9c expires after 48h 🎪 ec70a9c 🌐 54.188.63.112:8080 Environment ec70a9c URL: http://54.188.63.112:8080 (click to visit) 🎪 ec70a9c 📅 2025-10-16T13-38 Environment ec70a9c created at 2025-10-16T13-38 preset-io size/S v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@betodealmeida @aminghadersohi @sadpandajoe