-
Notifications
You must be signed in to change notification settings - Fork 110
chore: Remove duplicate JOOQ generator and libraries #3748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
Updated Postgres image and changed checkout action version. Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
Removed installation of libncurses5 from the workflow. Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
…nyuan-remove-jooq-gen
Signed-off-by: Xinyuan Lin <[email protected]>
Add required status checks and pull request review settings for the main branch. Signed-off-by: Xinyuan Lin <[email protected]>
Removed unnecessary blank lines in .asf.yaml. Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
Signed-off-by: Xinyuan Lin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes redundant JOOQ code generation infrastructure after the functionality was merged into the sbt compiler. The cleanup eliminates duplicate dependencies and unused code to maintain a cleaner codebase.
- Removes the standalone JooqCodeGenerator class that is no longer needed
- Eliminates redundant dependencies for JOOQ code generation, PostgreSQL driver, and Typesafe config
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/dao/src/main/scala/edu/uci/ics/texera/dao/JooqCodeGenerator.scala | Complete removal of the standalone JOOQ code generator class |
| core/dao/build.sbt | Removal of redundant dependencies for code generation and configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@bobbai00 Please review this PR first. |
|
shall we merge this PR now? |
Waiting for @seongjinyoon to add an sbt shortcut to run JOOQ generator in case developers want to run it manually. It's not urgent. Will merge after fixing issue #3917 |
|
Just checking in on this — @seongjinyoon, any updates? |
I haven't started on this yet. I can prioritize it and give an update by Monday. |
|
This PR is ready. @bobbai00, please review it. |
Since the JOOQ code generator logic was merged into the sbt compiler in PR #3746, we no longer need a separate JOOQ generator class. This PR removes the redundant JOOQ generator along with its related libraries.
If you look at the file changes, the files removed in this PR are symmetrical to those added in PR #3746. We chose not to remove everything in the same PR to ensure the new generator worked as expected before deprecating the old one, and to keep each PR minimal and focused.