Skip to content

Conversation

@pjfanning
Copy link
Member

@pjfanning pjfanning commented Oct 28, 2025

What changes were proposed in this PR?

I had a look at the contrib docs because I am looking at Scala related task and the sbt commands seem out of date.
They seem to need to be run from the root dir of the project and not the core dir.

How was this PR tested?

CI build

Was this PR authored or co-authored using generative AI tooling?

No

@github-actions github-actions bot added the docs Changes related to documentations label Oct 28, 2025
@chenlica chenlica requested review from aicam and bobbai00 October 29, 2025 19:23
@chenlica
Copy link
Contributor

@bobbai00 @aicam : can you review this PR?

Copy link
Contributor

@bobbai00 bobbai00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobbai00 bobbai00 enabled auto-merge (squash) November 3, 2025 05:10
@bobbai00 bobbai00 disabled auto-merge November 3, 2025 05:10
@bobbai00
Copy link
Contributor

bobbai00 commented Nov 3, 2025

Thanks for the fix. Can you change the PR description to use the PR template?

Copy link
Contributor

@aicam aicam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it

@pjfanning
Copy link
Member Author

looks like #4018 fixed this

@pjfanning pjfanning closed this Nov 19, 2025
@pjfanning pjfanning deleted the pjfanning-patch-1 branch November 19, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Changes related to documentations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants