Skip to content

Conversation

@DrGreekenstein
Copy link
Contributor

This PR removes the JS date formatting, fixes an unclosed div tag and removes the duplicate src attribute in an image.
Issue - "Why assume US date format? #565"

Please feel free to review or adjust as needed.

@sebbASF
Copy link
Contributor

sebbASF commented Nov 12, 2025

Sorry, but the proposed solution does not work.
The website is built with Pelican, not Hugo.
The new lines after '[for foundation]' and before '[end]' cause the html to be treated as text.

Also please do not mix independent changes in a single PR.

@DrGreekenstein
Copy link
Contributor Author

i am really sorry for overlooking that detail, i will correct and submit again

@sebbASF sebbASF marked this pull request as draft November 13, 2025 09:17
@DrGreekenstein DrGreekenstein force-pushed the fix/date-time-issue-in-index branch from 6dc10a6 to 86e8eba Compare November 13, 2025 09:38
@DrGreekenstein DrGreekenstein changed the title www-site: Replace JS date formatting with Hugo :date_long + fix hero www-site: Replace JS date formatting with Pelican + fix hero Nov 13, 2025
@DrGreekenstein DrGreekenstein marked this pull request as ready for review November 13, 2025 09:40
@sebbASF sebbASF marked this pull request as draft November 13, 2025 11:41
@sebbASF
Copy link
Contributor

sebbASF commented Nov 13, 2025

The PR still includes the hero fix (which I put in a separate PR) - please remove it.

Also, this page uses ezt templating; this needs to be retained or there will likely be issues.

Have you tested the changes?

sebbASF added a commit that referenced this pull request Nov 13, 2025
@sebbASF
Copy link
Contributor

sebbASF commented Nov 13, 2025

I created a preview branch at https://github.com/apache/www-site/tree/preview/issue-565
This is a copy of main, but using index.ezmd from this PR.

The resulting site can be seen at:
https://www-issue-565.staged.apache.org/

There are a couple of issues with the output:

@sebbASF
Copy link
Contributor

sebbASF commented Nov 13, 2025

If you want to test changes locally, please follow the instructions here:

https://github.com/apache/www-site/blob/main/README.md#local-development-and-testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants