Skip to content

Conversation

devyeony
Copy link
Contributor

What is this PR for?

  • This PR adds comprehensive E2E tests for the Job Manager feature using Playwright. The Job Manager is a feature in Zeppelin that allows users to monitor and manage running jobs/notebooks. These tests ensure the Job Manager UI works correctly across different states and user interactions.

What type of PR is it?

Improvement

Todos

  • Create Job Manager page object model (JobManagerPage)
  • Create Job Card component model (JobCard)
  • Create Job Manager utility helper (JobManagerUtil)
  • Add system states tests (disabled, loading, success states)
  • Add filter controls tests (search, interpreter filter, sort)
  • Add job cards tests (display, status, controls)
  • Add status legend tests (badge display and counts)

What is the Jira issue?

How should this be tested?

  • Run the Job Manager Playwright E2E tests.

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Contributor

@dididy dididy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for writing E2E tests!

https://github.com/apache/zeppelin/actions/runs/18528370510/job/52804535917?pr=5106

It seems that some tests are failing. Please take a look at this issue.

Also, for the Job Manager feature, the zeppelin.jobmanager.enable property in conf/zeppelin-site.xml must be set to true, as shown below:

<property>
  <name>zeppelin.jobmanager.enable</name>
  <value>true</value>
  <description>The Job tab in the Zeppelin page seems not so useful; however, it costs lots of memory and affects performance. Disabling it can save memory.</description>
</property>

dididy@0720819
Therefore, as shown in the above commit, this option should also be added in the CI configuration. It seems that some tests are failing even after applying the above configuration(zeppelin.jobmanager.enable=true) locally. Please take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants