Skip to content

fix(kafka): resolve memory refs per action container - #3249

Draft
weicao wants to merge 1 commit into
audrey/task55-heap-40from
audrey/task56-backup-resourcefieldref
Draft

fix(kafka): resolve memory refs per action container#3249
weicao wants to merge 1 commit into
audrey/task55-heap-40from
audrey/task56-backup-resourcefieldref

Conversation

@weicao

@weicao weicao commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Problem

Fresh task54 backup runtime on exact addon 2067c105 created an action Pod with only backupdata and manager containers. Both failed with container kafka not found because four Kafka ComponentDefinitions hard-coded resourceFieldRef.containerName: kafka for KB_KAFKA_CONTAINER_MEMORY_LIMIT_MIB.

Change

  • remove the hard-coded container name from the four Kafka ComponentDefinitions so Kubernetes resolves limits.memory against the container executing the action
  • add a structured Helm-render regression test that requires exactly the four Kafka definitions to expose the memory env with resource=limits.memory, divisor=1Mi, and no container override

Verification

  • focused TDD: 1 failing example before the template change, then 1/0
  • full Kafka ShellSpec with Bash 5.3: 31/0
  • Bash 3.2 runnable subset: 9/0
  • sh -n, Ruby syntax, ShellCheck, and git diff --check: pass

Stacked on #3248 exact addon head; kept Draft because the base is a custom branch.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (2067c10) to head (2bf7ece).

Files with missing lines Patch % Lines
...kafka/scripts-ut-spec/container_memory_ref_spec.sh 0.00% 25 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           audrey/task55-heap-40   #3249   +/-   ##
=====================================================
  Coverage                   0.00%   0.00%           
=====================================================
  Files                         76      77    +1     
  Lines                       9426    9451   +25     
=====================================================
- Misses                      9426    9451   +25     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants