fix(kafka): resolve memory refs per action container - #3249
Draft
weicao wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## audrey/task55-heap-40 #3249 +/- ##
=====================================================
Coverage 0.00% 0.00%
=====================================================
Files 76 77 +1
Lines 9426 9451 +25
=====================================================
- Misses 9426 9451 +25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fresh task54 backup runtime on exact addon
2067c105created an action Pod with onlybackupdataandmanagercontainers. Both failed withcontainer kafka not foundbecause four Kafka ComponentDefinitions hard-codedresourceFieldRef.containerName: kafkaforKB_KAFKA_CONTAINER_MEMORY_LIMIT_MIB.Change
limits.memoryagainst the container executing the actionresource=limits.memory,divisor=1Mi, and no container overrideVerification
sh -n, Ruby syntax, ShellCheck, andgit diff --check: passStacked on #3248 exact addon head; kept Draft because the base is a custom branch.