fix(etcd): fail role probe on status errors - #3267
Draft
weicao wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## martin/etcd-memberjoin-idempotency #3267 +/- ##
==================================================================
Coverage 0.00% 0.00%
==================================================================
Files 150 150
Lines 23843 23932 +89
==================================================================
- Misses 23843 23932 +89 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
weicao
force-pushed
the
martin/etcd-roleprobe-fail-closed
branch
from
July 26, 2026 06:25
35c36d2 to
276a9b4
Compare
leon-ape
marked this pull request as draft
July 27, 2026 01:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
roleprobe.shreturned exit code 0 with empty stdout whenetcdctl endpoint statusfailed because the top-level command substitution did not propagateget_etcd_rolefailure. A successful but malformed endpoint response could also produce a false role.Change
get_etcd_rolefailure from the script entrypointVerification
shellspec --load-path ./shellspec --shell /opt/homebrew/bin/bash addons/etcd/scripts-ut-spec/roleprobe_spec.sh: 19 examples, 0 failuresshellspec --load-path ./shellspec --default-path addons/etcd/scripts-ut-spec --shell /opt/homebrew/bin/bash: 84 examples, 0 failuresbash -n addons/etcd/scripts/roleprobe.shshellcheck addons/etcd/scripts/roleprobe.shgit diff --check 79c82e3ba6adb532625295a78046b82edd3a2d90..HEADThis PR is intentionally stacked on exact candidate head
79c82e3ba6adb532625295a78046b82edd3a2d90and does not change the peer-network/TLS topology path.