Skip to content

fix(rustfs): remove backup capability from runtime baseline - #3271

Draft
weicao wants to merge 2 commits into
jessica/rustfs-backup-roleprobe-candidatefrom
jessica/rustfs-remove-dp-runtime-baseline
Draft

fix(rustfs): remove backup capability from runtime baseline#3271
weicao wants to merge 2 commits into
jessica/rustfs-backup-roleprobe-candidatefrom
jessica/rustfs-remove-dp-runtime-baseline

Conversation

@weicao

@weicao weicao commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Problem

The first DP-removal candidate was based on the older product head and dropped the validated runtime baseline's roleProbe.periodSeconds: 1 and timeoutSeconds: 3. A live addon upgrade then failed closed because those ComponentDefinition fields are immutable.

Change

  • start from exact runtime combined baseline bbc7da4602fdcb1db55e0f423e1dd75f9e9f8605
  • remove only RustFS generic BackupPolicyTemplate, ActionSet, backup/restore scripts, and backup-only values/helper
  • preserve roleProbe timing 1s/3s
  • extend the negative capability contract to lock both DP absence and roleProbe timing

Evidence

  • RED on prior candidate 5a9a67546fe8d8b121ffb18e76c3ce2ff3b67248: contract rc1, missing periodSeconds: 1
  • GREEN on 956dc71742cefae1f84b893201b4431c7c5d2aae
  • Bash 5 ShellSpec 54/0; Bash 3 ShellSpec 7/0
  • Helm lint/render, bash-n, ShellCheck error, diff-check PASS
  • baseline render with only BPT/ActionSet documents filtered out is byte-identical to successor render
  • successor render contains roleProbe periodSeconds: 1 and timeoutSeconds: 3

Boundary

Source/offline successor only. The Test owner must independently freeze, live-upgrade, run clean-full, seal evidence, and clean normally before any runtime/formal-N claim.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (bbc7da4) to head (956dc71).

Files with missing lines Patch % Lines
...scripts-ut-spec/no_dataprotection_contract_test.sh 0.00% 43 Missing ⚠️
...scripts-ut-spec/no_dataprotection_contract_spec.sh 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                             @@
##           jessica/rustfs-backup-roleprobe-candidate   #3271    +/-   ##
==========================================================================
  Coverage                                       0.00%   0.00%            
==========================================================================
  Files                                            162     162            
  Lines                                          24962   24748   -214     
==========================================================================
+ Misses                                         24962   24748   -214     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants