fix(mongodb): fail closed on uncertain member role - #3275
Draft
weicao wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3275 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 165 166 +1
Lines 25632 25677 +45
=====================================
- Misses 25632 25677 +45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mongodb-member-leave.shdiscarded the exit status fromsyncerctl getrole.That made an uncertain role observation fail open: a timeout (
124) or anotherprobe failure (
7) with stalesecondaryoutput fell through tosyncerctl leaveand returned success.This conflicts with the addon lifecycle contract that member-leave actions
must repeat or fail safely and that diagnostic failures remain distinct from
successful convergence.
Change
and do not invoke
leave.primaryrejection.KB_LEAVE_MEMBER_POD_NAMEas the leave identity.syncerctl leaveas the terminal command so its exit status propagates.Test-first evidence
Exact test-only parent
086e64d277761ee8d750e0d08e5775585d1ba91c:4 examples, 2 failures4 examples, 2 failures124and probe rc7with stalesecondary; bothincorrectly returned
0and invoked leave.Exact implementation head
8f4da6594ef752a183eeb5226777c40c02cf757c:5/0each83/0eachstrict fsck, ASCII, credential-shape, and clean-worktree gates pass.
APPROVE/BLOCKER_LIST0.Review focus
leaveThis PR proves the repository source/test contract only. It does not claim
package, Kubernetes, controller, syncer runtime, deployment, release, or
accepted test-run results.