feat(falkordb): use non-blocking shard removal - #3284
Closed
leon-ape wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3284 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 164 164
Lines 25589 25589
=====================================
Misses 25589 25589 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Superseded by #3285, which consolidates the MongoDB, FalkorDB, and Redis shard-removal adaptations into one PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Enable
nonBlockingfor the FalkorDBshardRemovelifecycle action.Why
FalkorDB shard removal rebalances slots to zero and removes the shard nodes. The duration depends on data volume and cluster conditions and can exceed the synchronous Action limit. KubeBlocks can now persist the selected targets and poll this action until it reaches a terminal result.
User impact
FalkorDB scale-in no longer depends on the shard-removal command finishing within one synchronous controller call. This requires apecloud/kubeblocks#10725.
Validation
helm dependency build addons/falkordbhelm lint addons/falkordbhelm template falkordb addons/falkordband verifiedspec.lifecycleActions.shardRemove.nonBlocking: true