Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rendering negative area chart with lines of any color #5002

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

elaaksonen
Copy link

The negative area chart is very useful, but currently it cannot be combined with other series because all series are painted with the same pattern.

New Pull Request

To enable drawing other series (indicator and signal lines) next to negative area chart, the negative area coloring should be only applied to specific series and not all of them. To enable this feature, enabledOnSeries prop was added to the plotOptions.line.

Bunch of unit tests are breaking on main without my change, so I am not sure how to cleanly test it.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
    Unit tests don't pass on clean main.
  • My branch is up to date with any changes from the main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant