Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 27, 2025

Two create() method signatures were inadvertently changed from optional to required parameters during JSDoc additions, breaking backward compatibility.

Changes

  • schedule_collection.ts: Restored create(schedule?: ScheduleCreateOrUpdateData) parameter optionality
  • webhook_collection.ts: Restored create(webhook?: WebhookUpdateData) parameter optionality

Both methods use ow.optional.object validation internally, confirming the parameters should be optional.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Contributor Author

Copilot AI commented Nov 27, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • googlechromelabs.github.io
    • Triggering command: /usr/local/bin/node node install.mjs (dns block)
  • https://storage.googleapis.com/chrome-for-testing-public/142.0.7444.175/linux64/chrome-linux64.zip
    • Triggering command: /usr/local/bin/node node install.mjs (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update JSDocs based on the API reference Fix inadvertent parameter optionality changes in create methods Nov 27, 2025
Copilot AI requested a review from jancurn November 27, 2025 23:50
Copilot finished work on behalf of jancurn November 27, 2025 23:50
@jancurn jancurn marked this pull request as ready for review November 28, 2025 01:53
@jancurn jancurn merged commit 1b49bdd into feat/jsdocs Nov 28, 2025
@jancurn jancurn deleted the copilot/sub-pr-797 branch November 28, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants