Skip to content

fix: use the configured public API URL in Actor.new_client - #1229

Merged
vdusek merged 3 commits into
masterfrom
fix/new-client-public-url
Nov 4, 2026
Merged

vdusek merged 3 commits into
masterfrom
fix/new-client-public-url

Conversation

@vdusek

@vdusek vdusek commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Actor.new_client() did not pass api_public_url to ApifyClientAsync, so the public URLs its clients build (for example from get_record_public_url) always pointed to https://api.apify.com, which is wrong on any non-production API. It takes the value from APIFY_API_PUBLIC_BASE_URL via the configuration, the same way the SDK's storage clients and the JS Actor.newClient() do, and accepts an api_public_url override next to api_url.

✍️ Drafted by Claude Code

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Nov 4, 2026
@vdusek vdusek self-assigned this Nov 4, 2026
@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.81%. Comparing base (46824ef) to head (6477825).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1229      +/-   ##
==========================================
- Coverage   93.84%   93.81%   -0.03%     
==========================================
  Files          54       54              
  Lines        3800     3800              
==========================================
- Hits         3566     3565       -1     
- Misses        234      235       +1     
Flag Coverage Δ
e2e 31.47% <ø> (ø)
integration 51.39% <ø> (-0.03%) ⬇️
unit 91.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek requested a review from apify-factory November 4, 2026 13:26
@vdusek
vdusek marked this pull request as ready for review November 4, 2026 13:26
@apify-service-account apify-service-account added the tested Temporary label used only programatically for some analytics. label Nov 4, 2026
apify-factory
apify-factory previously approved these changes Nov 4, 2026

@apify-factory apify-factory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nothing blocking.

🏭 Apify Factory auto approved ✅ — green across the board, coffee break earned

Every gate passed, and neither the reviewer nor a juror found anything a human needs to look at.

Approval locked to 10c903dc6 · workflow run

@vdusek
vdusek requested a review from szaganek as a code owner November 4, 2026 13:36
@apify-factory
apify-factory dismissed their stale review November 4, 2026 13:36

Withdrawn because the content changed since the last verdict, and pushes are not re-reviewed.

@vdusek
vdusek requested a review from apify-factory November 4, 2026 13:44

@apify-factory apify-factory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nothing blocking.

🏭 Factory review — ℹ️ not auto-approved

This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.

check result
Static gates ❌ 15/16 — file-extensions
Review findings ✅ none
Reviewer escalation ✅ none
Juror 1 — claude-sonnet-5-5, adversarial ⏭️ skipped — a gate failed
Why it was not auto-approved

Failed gates:

  • file-extensions: disallowed extension: docs/02_concepts/08_access_apify_api.mdx

The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.

Reviewed 6477825c5 · workflow run

@vdusek
vdusek requested review from Mantisus and Pijukatel November 4, 2026 13:46

@Mantisus Mantisus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apify-approval-mirror apify-approval-mirror Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mirroring approval from @Mantisus.

@vdusek
vdusek merged commit fe2f960 into master Nov 4, 2026
43 checks passed
@vdusek
vdusek deleted the fix/new-client-public-url branch November 4, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants