Repository navigation
fix: use the configured public API URL in Actor.new_client - #1229
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1229 +/- ##
==========================================
- Coverage 93.84% 93.81% -0.03%
==========================================
Files 54 54
Lines 3800 3800
==========================================
- Hits 3566 3565 -1
- Misses 234 235 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
apify-factory
left a comment
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Apify Factory auto approved ✅ — green across the board, coffee break earned
Every gate passed, and neither the reviewer nor a juror found anything a human needs to look at.
Approval locked to 10c903dc6 · workflow run
Withdrawn because the content changed since the last verdict, and pushes are not re-reviewed.
apify-factory
left a comment
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Factory review — ℹ️ not auto-approved
This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.
| check | result |
|---|---|
| Static gates | ❌ 15/16 — file-extensions |
| Review findings | ✅ none |
| Reviewer escalation | ✅ none |
Juror 1 — claude-sonnet-5-5, adversarial |
⏭️ skipped — a gate failed |
Why it was not auto-approved
Failed gates:
file-extensions: disallowed extension: docs/02_concepts/08_access_apify_api.mdx
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed 6477825c5 · workflow run
Actor.new_client()did not passapi_public_urltoApifyClientAsync, so the public URLs its clients build (for example fromget_record_public_url) always pointed tohttps://api.apify.com, which is wrong on any non-production API. It takes the value fromAPIFY_API_PUBLIC_BASE_URLvia the configuration, the same way the SDK's storage clients and the JSActor.newClient()do, and accepts anapi_public_urloverride next toapi_url.✍️ Drafted by Claude Code