Skip to content

feat: run without proxy locally when the proxy password is missing - #1231

Open
vladfrangu wants to merge 1 commit into
masterfrom
feat/proxy-local-no-password-warns
Open

vladfrangu wants to merge 1 commit into
masterfrom
feat/proxy-local-no-password-warns

Conversation

@vladfrangu

Copy link
Copy Markdown
Member

When Apify Proxy is requested in a local run and no password is available (neither password, APIFY_PROXY_PASSWORD, nor a token to fetch it with), the SDK now logs a warning and runs without a proxy instead of raising. On the platform the existing ValueError is unchanged. This matches the JS SDK after apify/apify-sdk-js#824.

  • ProxyConfiguration.initialize() returns bool: False when it fell back to running without proxy, True otherwise. The access check is skipped in the fallback case, so no proxy URL is built with an empty password.
  • Actor.create_proxy_configuration() returns None when initialize() returns False.
  • A failed token lookup, a connected: false status check, and a timed-out status check behave as before.

[🤖] Claude Code using Opus 5.5

@vladfrangu vladfrangu self-assigned this Nov 4, 2026
@vladfrangu
vladfrangu requested review from szaganek and vdusek November 4, 2026 22:55
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Nov 4, 2026
@apify-service-account apify-service-account added the tested Temporary label used only programatically for some analytics. label Nov 4, 2026
@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.82%. Comparing base (793991b) to head (3a2ced8).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1231      +/-   ##
==========================================
- Coverage   93.84%   93.82%   -0.02%     
==========================================
  Files          54       54              
  Lines        3800     3806       +6     
==========================================
+ Hits         3566     3571       +5     
- Misses        234      235       +1     
Flag Coverage Δ
e2e 31.42% <11.11%> (-0.05%) ⬇️
integration 51.31% <11.11%> (-0.11%) ⬇️
unit 91.01% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants