Repository navigation
feat: run without proxy locally when the proxy password is missing - #1231
Open
vladfrangu wants to merge 1 commit into
Open
vladfrangu wants to merge 1 commit into
vladfrangu wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1231 +/- ##
==========================================
- Coverage 93.84% 93.82% -0.02%
==========================================
Files 54 54
Lines 3800 3806 +6
==========================================
+ Hits 3566 3571 +5
- Misses 234 235 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Apify Proxy is requested in a local run and no password is available (neither
password,APIFY_PROXY_PASSWORD, nor a token to fetch it with), the SDK now logs a warning and runs without a proxy instead of raising. On the platform the existingValueErroris unchanged. This matches the JS SDK after apify/apify-sdk-js#824.ProxyConfiguration.initialize()returnsbool:Falsewhen it fell back to running without proxy,Trueotherwise. The access check is skipped in the fallback case, so no proxy URL is built with an empty password.Actor.create_proxy_configuration()returnsNonewheninitialize()returnsFalse.connected: falsestatus check, and a timed-out status check behave as before.[🤖] Claude Code using Opus 5.5