Skip to content

fix: preserve max_total_charge_usd=0 instead of treating it as unlimited #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 2 commits into from
Apr 20, 2026
Merged

fix: preserve max_total_charge_usd=0 instead of treating it as unlimited #870

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bf8c92
fix: preserve `max_total_charge_usd=0` instead of treating it as unli…
vdusek Apr 20, 2026
ce7bcbd
test: cover `max_total_charge_usd=0` at the charging manager boundary
vdusek Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/apify/_charging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,9 @@ class ChargingManagerImplementation(ChargingManager):
LOCAL_CHARGING_LOG_DATASET_NAME = 'charging-log'

def __init__(self, configuration: Configuration, client: ApifyClientAsync) -> None:
self._max_total_charge_usd = configuration.max_total_charge_usd or Decimal('inf')
self._max_total_charge_usd = (
configuration.max_total_charge_usd if configuration.max_total_charge_usd is not None else Decimal('inf')
)
self._configuration = configuration
self._is_at_home = configuration.is_at_home
self._actor_run_id = configuration.actor_run_id
Expand Down Expand Up @@ -413,7 +415,11 @@ async def _fetch_pricing_info(self) -> _FetchedPricingInfoDict:
return _FetchedPricingInfoDict(
pricing_info=self._configuration.actor_pricing_info,
charged_event_counts=self._configuration.charged_event_counts,
max_total_charge_usd=self._configuration.max_total_charge_usd or Decimal('inf'),
max_total_charge_usd=(
self._configuration.max_total_charge_usd
if self._configuration.max_total_charge_usd is not None
else Decimal('inf')
),
)

# Fall back to API call
Expand All @@ -436,7 +442,11 @@ async def _fetch_pricing_info(self) -> _FetchedPricingInfoDict:
return _FetchedPricingInfoDict(
pricing_info=None,
charged_event_counts={},
max_total_charge_usd=self._configuration.max_total_charge_usd or Decimal('inf'),
max_total_charge_usd=(
self._configuration.max_total_charge_usd
if self._configuration.max_total_charge_usd is not None
else Decimal('inf')
),
)

def _get_event_price(self, event_name: str) -> Decimal:
Expand Down
Loading