Skip to content

refactor!: Introduce IBrowserPool interface and utilize it in BrowserCrawler#3669

Merged
janbuchar merged 14 commits into
v4from
browser-pool-interface-simplification
Jun 10, 2026
Merged

refactor!: Introduce IBrowserPool interface and utilize it in BrowserCrawler#3669
janbuchar merged 14 commits into
v4from
browser-pool-interface-simplification

Conversation

@janbuchar

Copy link
Copy Markdown
Contributor

@janbuchar janbuchar added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels May 22, 2026
@janbuchar janbuchar requested review from B4nan, barjin and l2ysho May 22, 2026 09:49

@barjin barjin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @janbuchar, for driving this forward 🙌

I generally like the direction this is going, I'd be even stricter about the abstraction in the IBrowserPool interface ⬇️ Wdyt?

Comment thread packages/types/src/browser.ts Outdated
Comment thread packages/browser-crawler/src/internals/browser-crawler.ts Outdated
Comment thread packages/browser-crawler/src/internals/browser-crawler.ts Outdated
Comment thread packages/browser-crawler/src/internals/browser-crawler.ts Outdated
Comment thread packages/types/src/browser.ts
@janbuchar janbuchar self-assigned this May 28, 2026
Comment thread packages/browser-crawler/src/internals/browser-crawler.ts Outdated
@janbuchar janbuchar requested review from B4nan and barjin May 28, 2026 16:49
@janbuchar

Copy link
Copy Markdown
Contributor Author

@B4nan @barjin another iteration, please check it out 🙂

Comment thread packages/browser-crawler/src/internals/browser-crawler.ts Outdated

@barjin barjin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, few last questions / nits, but looks good to me otherwise 👍

Comment thread docs/upgrading/upgrading_v4.md Outdated
Comment thread packages/browser-crawler/src/internals/browser-crawler.ts
Comment thread packages/types/src/browser.ts
@janbuchar janbuchar requested a review from barjin June 9, 2026 14:52

@barjin barjin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one small nit regarding the ignoreTlsErrors as discussed ⬇️

Thanks!

@janbuchar janbuchar merged commit ebb1b26 into v4 Jun 10, 2026
6 checks passed
@janbuchar janbuchar deleted the browser-pool-interface-simplification branch June 10, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants