refactor!: Rewrite the FilesystemStorageClient to use apify/crawlee-storage#3762
Open
janbuchar wants to merge 35 commits into
Open
refactor!: Rewrite the FilesystemStorageClient to use apify/crawlee-storage#3762janbuchar wants to merge 35 commits into
janbuchar wants to merge 35 commits into
Conversation
janbuchar
commented
Jun 18, 2026
janbuchar
commented
Contributor
- closes Use apify/crawlee-storage to implement a filesystem-backed storage client #3735
janbuchar
added
the
t-tooling
janbuchar
commented
Jun 25, 2026
Contributor
Author
|
@vladfrangu this touches a guide you wrote, please make sure I didn't ruin it. |
barjin
reviewed
Jun 25, 2026
barjin
left a comment
barjin
left a comment
Member
There was a problem hiding this comment.
Thank you @janbuchar! here's my few first ideas ⬇️
barjin
approved these changes
Jun 30, 2026
barjin
left a comment
barjin
left a comment
Member
There was a problem hiding this comment.
Thank you @janbuchar , I have no further objections. See minuscule nits below ⬇️
barjin
reviewed
Jun 30, 2026
B4nan
approved these changes
Jul 1, 2026
B4nan
left a comment
B4nan
left a comment
Member
There was a problem hiding this comment.
some examples are missing the newly required localDataDirectory
Member
|
e2e tests running here: https://github.com/apify/crawlee/actions/runs/28510390131 |
Member
|
e2e tests are broken, not sure if they were working in v4 before, but this is exactly the kind of PR I would like to test through those |
Contributor
Author
About that... #3805 — I wouldn't block on fixing the complete E2E test suite 💀 |
…ncies' into rust-storages # Conflicts: # packages/fs-storage/src/resource-clients/key-value-store.ts # packages/fs-storage/src/resource-clients/request-queue.ts # packages/fs-storage/test/request-queue/dangling-forefront-on-reload.test.ts # packages/fs-storage/test/request-queue/forefront.test.ts # packages/fs-storage/test/request-queue/ignore-non-json-files.test.ts # pnpm-lock.yaml
janbuchar
changed the base branch from
v4
to
fix-storage-interface-inconsistencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.