update resource attribute docs #6780
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 3 changed, 0 removedBuild ID: be0cc77d980314c90cf7053f URL: https://www.apollographql.com/docs/deploy-preview/be0cc77d980314c90cf7053f |
lrlna
requested review from
BrynCooke and
bnjjj
and removed request for
a team
|
@lrlna, please consider creating a changeset entry in |
lrlna
commented
Feb 19, 2025
docs/source/routing/observability/telemetry/log-exporters/overview.mdx
Outdated
Show resolved
Hide resolved
docs/source/routing/observability/telemetry/metrics-exporters/overview.mdx
Outdated
Show resolved
Hide resolved
docs/source/routing/observability/telemetry/trace-exporters/overview.mdx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our docs are suggesting to use
environment.namein telemetry's resource attributes, which isn't a semantically correct resource definition according to otel's resource deployment environment's docs.Similarly, we are pointing to
environment.namespace, which also doesn't exist in otel's semantic convention's docs. Since we are pointing to k8's namespace environment variable in the examples, we are likely wanting to show to attribute this tok8s.namespace.nameinstead, which is described in this section of otel docs. Although, I could see that this could also potentially be aservice.namespaceattribute as well.