delivery attempt in retries fix #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tusharmndr
reviewed
Apr 22, 2025
| @@ -338,7 +338,7 @@ private boolean process(final InternalMessage<M> internalMessage) { | |||
| } | |||
| else { | |||
| status = actor.retryer.execute(() -> { | |||
| messageMeta.updateAttempt(attempt.getAndIncrement()); | |||
| messageMeta.updateAttempt(messageMeta.getDeliveryAttempt().incrementAndGet()); | |||
There was a problem hiding this comment.
implement increment function in message meta and lets remove updateAttempt as a function
santanusinha
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/appform-io/memq/blame/3e04f3201406e4331c7001d9e529a57d9fc162fb/memq-actor/src/main/java/io/appform/memq/actor/Actor.java#L341
it is not incrementing the attempt value as expected across various retries. The value is coming as 1 only for multiple retries