-
Couldn't load subscription status.
- Fork 500
Specify ip in --network #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
siikamiika
wants to merge
7
commits into
apple:main
Choose a base branch
from
siikamiika:container-run-network-ip
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d249605
Specify ip in --network
siikamiika 8def4b9
Validate NetworkArg unhandled arguments
siikamiika 462598c
Reserve static ip from allocator
siikamiika 1893a7b
NetworkArg inside Flags
siikamiika 9371caa
Update command reference
siikamiika 1f120ca
Add integration test for --network ip
siikamiika a8b10ce
Run make fmt
siikamiika File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,4 +21,5 @@ public enum NetworkKeys: String { | |
| case hostname | ||
| case network | ||
| case state | ||
| case ip | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,6 +88,52 @@ class TestCLINetwork: CLITest { | |
| } | ||
| } | ||
|
|
||
| @available(macOS 26, *) | ||
| @Test func testNetworkStaticIp() async throws { | ||
| do { | ||
| let name = getLowercasedTestName() | ||
| let networkDeleteArgs = ["network", "delete", name] | ||
| _ = try? run(arguments: networkDeleteArgs) | ||
|
|
||
| let networkCreateArgs = ["network", "create", name] | ||
| let result = try run(arguments: networkCreateArgs) | ||
| if result.status != 0 { | ||
| throw CLIError.executionFailed("command failed: \(result.error)") | ||
| } | ||
|
|
||
| let networkInspectOutput = try inspectNetwork(name) | ||
| guard let networkInspectStatus = networkInspectOutput.status else { | ||
| throw CLIError.invalidOutput("network inspect output invalid, missing status") | ||
| } | ||
| let network = try CIDRAddress(networkInspectStatus.address) | ||
| var addressBytes = network.address.networkBytes | ||
| addressBytes[3] = UInt8.random(in: 10...100) | ||
| let staticIp = try IPv4Address(fromNetworkBytes: addressBytes).description | ||
|
Comment on lines
+104
to
+111
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Getting a static ip for testing is a bit difficult without a static subnet (#737) but should work |
||
|
|
||
| defer { | ||
| _ = try? run(arguments: networkDeleteArgs) | ||
| } | ||
| try doLongRun( | ||
| name: name, | ||
| image: "docker.io/library/alpine", | ||
| args: ["--network", "\(name):ip=\(staticIp)"], | ||
| containerArgs: ["sleep", "infinity"]) | ||
| defer { | ||
| try? doStop(name: name) | ||
| } | ||
|
|
||
| let container = try inspectContainer(name) | ||
| #expect(container.networks.count > 0) | ||
| let cidrAddress = try CIDRAddress(container.networks[0].address) | ||
| #expect(cidrAddress.address.description == staticIp, "expected static ip \(staticIp), got \(cidrAddress.address.description)") | ||
|
|
||
| try doStop(name: name) | ||
| } catch { | ||
| Issue.record("failed to use a static IP in network \(error)") | ||
| return | ||
| } | ||
| } | ||
|
|
||
| @available(macOS 26, *) | ||
| @Test func testNetworkDeleteWithContainer() async throws { | ||
| do { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When trying to reserve gateway ip 192.168.64.1:
When trying to reserve already allocated ip 192.168.64.12: