Allow reusing virtiofs mounts #243
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fwiw, this is a bit odd, but it's also very simple to support and feels odd that this was failing today. This also adds in a tiny bit of logic in hashMountSource to resolve the path of symlinks, so now even symlinks to the same dir can be supplied N times without a new virtiofs device.
1 task
|
Was just looking at apple/container#380. Did we intentionally let this go dormant for some reason? |
|
Just no one reviewed is all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fwiw, this is a bit odd, but it's also very simple to support and feels odd that this was failing today. This also adds in a tiny bit of logic in hashMountSource to resolve the path of symlinks, so now even symlinks to the same dir can be supplied N times without a new virtiofs device.