Fix cat dim on packed intx tensors - #41
Open
eyupcanakman wants to merge 2 commits into
Open
Conversation
The aten.cat branch of SubbyteTensor.__torch_dispatch__ reads dim via fill_defaults, then calls the op without it, so every cat runs on dim 0. Two (2, 4) tensors with dim=1 give shape (4, 4) rather than (2, 8). IntxTensor and UintxTensor share the branch, so both are affected.
jakesabathia2
self-requested a review
July 23, 2026 18:51
jakesabathia2
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the great fix! @eyupcanakman
jakesabathia2
approved these changes
Jul 23, 2026
Contributor
|
There was some format issue @eyupcanakman. After fixing this please let me know and I can do the review again 😸 |
Contributor
Author
|
That format failure is ruff 0.16.0, which started formatting python code blocks inside .md files. CI installs the newest ruff from the dev extra while pre-commit pins v0.12.8, so the six docs files it flags fail on a clean main too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Testing