Skip to content

Bump swift-collections to 1.1.1 #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

yutailang0119
Copy link

@yutailang0119 yutailang0119 commented Jun 27, 2024

Information

  • Package version: 1.0.1
  • Swift version: 5.10

Behavior

The app upload to App Store Connect fails due to swift-collections, when not using SWIFTCI_USE_LOCAL_DEPS.
This issue has been reported in apple/swift-collections#364.
This package needs to be updated to version 1.1.1.

@FranzBusch
Copy link
Member

It shouldn't be necessary for us to increase the minimum version here. In your application you should be able to update to the latest package versions which should pull in the 1.1.1 release if swift-collections.

@yutailang0119
Copy link
Author

In many cases, that is correct, but it can cause issues due to caches and other factors.
Since I know there are problems with swift-collections v1.1.0, it would be helpful to explicitly update the minimum version.

@FranzBusch
Copy link
Member

I understand how it can still result in build failures but I disagree on bumping the version here. This isn't going to be sustainable across the ecosystem that every single package is bumping their minimum version for a build fix from one of its dependencies.

@yutailang0119
Copy link
Author

OK, I will consider explicitly adding a dependency on swift-collections v1.1.1 in my app.
Thanks!

@yutailang0119 yutailang0119 deleted the bump-swift-collections branch June 28, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants