Fixed WorkerPool to handle remote actors properly #1164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akbashev
commented
Oct 15, 2024
akbashev
commented
Oct 15, 2024
|
Hm, would be nice to add test to check remote actors also. |
ktoso
reviewed
Oct 16, 2024
ktoso
reviewed
Oct 16, 2024
|
@swift-server-bot test this please |
ktoso
approved these changes
Nov 8, 2024
# Conflicts: # Sources/DistributedCluster/InvocationBehavior.swift # Sources/DistributedCluster/Pattern/WorkerPool.swift # Sources/DistributedCluster/WeakActorDictionary.swift # Tests/DistributedClusterTests/Pattern/WorkerPoolTests.swift
|
@ktoso ClusterSingletonPluginClusteredTests is flacky, also seen it failing in main branch, need to check it separately. |
|
Hm yeah some tests are flaky, the docs validation is also failing. This did pass on many runs though so I'm ok to merge and we need to get CI more stable eventually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently WorkerPool:
WorkItemandWorkResultare not marked asSendableThis PR fixes this, basically cherry picked changes from this PR #1159 and updated tests