[wip] Fixing memory leaks #1170
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akbashev
commented
Oct 25, 2024
Comment on lines
32
to
36
| public var events: ClusterEventStream { | ||
| self._events | ||
| } | ||
|
|
||
| internal var _events: ClusterEventStream |
Contributor
Author
There was a problem hiding this comment.
Don't know why I've added this 🫠 revert back
Member
|
The failure was #1089 again. We can merge with it failing as we need to investigate that one separately |
Member
|
We can disable the test until then as well |
ktoso
approved these changes
Oct 25, 2024
ktoso
reviewed
Oct 25, 2024
| deinit { | ||
| // self.shutdownFlag.destroy() | ||
|
|
||
| print("\(Self.self) DEINIT") |
ktoso
reviewed
Oct 25, 2024
|
|
||
| @usableFromInline | ||
| internal var _system: ClusterSystem? | ||
| internal weak var _system: ClusterSystem? |
Member
There was a problem hiding this comment.
heh yeah i can see that... previously actor trees destroyed things and now we don't i guess
ktoso
reviewed
Oct 25, 2024
Tests/DistributedClusterTests/Metrics/SWIMActorPeerMetricsTests.swift
Outdated
Show resolved
Hide resolved
ktoso
reviewed
Oct 25, 2024
Member
|
Still missing the latest changes probably and requiring 6.0? |
akbashev
force-pushed
the
memory_leak_fix
branch
from
939bee8 to
990ba04
Compare
# Conflicts: # Sources/DistributedActorsTestKit/LogCapture.swift # Sources/DistributedCluster/Cluster/ClusterShell.swift # Sources/DistributedCluster/Cluster/SWIM/SWIMActor.swift # Sources/DistributedCluster/Cluster/Transport/RemoteClusterActorPersonality.swift # Sources/DistributedCluster/ClusterSystem.swift # Sources/DistributedCluster/LifecycleMonitoring/LifecycleWatch.swift # Sources/DistributedCluster/LifecycleMonitoring/LifecycleWatchContainer.swift # Tests/DistributedClusterTests/Metrics/SWIMActorPeerMetricsTests.swift
format fix
akbashev
force-pushed
the
memory_leak_fix
branch
from
d6204a6 to
9705a56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RP to fix #1168