[DNM] Add LLDB formatters for types that live primarily in FoundationBase. #1187
Conversation
| ConstString("CoreGraphics.CGFloat"), summary_flags); | ||
| AddStringSummary(swift_category_sp, "${var.native}", | ||
| ConstString("Foundation.CGFloat"), summary_flags); | ||
| AddStringSummary(swift_category_sp, "${var.native}", |
There was a problem hiding this comment.
So, is CGFloat living exclusively in FoundationBase? If so, the other formatter can be removed.
There was a problem hiding this comment.
Only in swift-corelibs-foundation. Does this cover Darwin too?
There was a problem hiding this comment.
Also, I'd like to be able to debug things built with swift-corelibs-foundation and Swift 4.x :)
There was a problem hiding this comment.
This covers everything (Darwin and Linux). If you really want to match both, use a regex instead of duplicating the code (see other examples, or ping me if you have issues).
Also, compiler and debugger are revlocked until swift grows a stable module format so the backcompatibility argument doesn't hold.
Thanks!
|
This is blocked by https://bugs.swift.org/browse/SR-9635. |
millenomi
force-pushed
the
swift-corelibs-foundation-split-soil
branch
from
19fcd66 to
90602cd
Compare
|
The problem you have is that swift and lldb are out of sync. |
dcci
left a comment
dcci
left a comment
There was a problem hiding this comment.
Mark as "requested changes" so that it gets out of my review queue.
millenomi
force-pushed
the
swift-corelibs-foundation-split-soil
branch
from
90602cd to
a6891e0
Compare
2 participants
This supports the change at swiftlang/swift-corelibs-foundation#1799.